acceptance: skip ruff prerequisite on DBR#5699
Draft
shreyas-goenka wants to merge 1 commit into
Draft
Conversation
The DBR test archive bundles only go, uv and jq (see internal/testarchive); ruff is neither bundled nor present on the serverless image. requirePrerequisites called RequireRuff unconditionally, so every DBR run failed fast before any test ran. No RunsOnDbr test exercises ruff (only the local-only check-formatting test does), so skip the check in DBR mode, mirroring the existing terraform skip. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 9a81e9f
23 interesting tests: 13 SKIP, 7 KNOWN, 2 FAIL, 1 flaky
Top 7 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every DBR acceptance test run (
./task dbr-test→TestDbrAcceptance) was failing immediately, before any test ran.The acceptance harness calls
requirePrerequisitesunconditionally, which callsRequireRuff. But the DBR test archive (internal/testarchive) bundles onlygo,uvandjq— ruff is neither bundled nor present on the serverless image, so the run fails fast with:No
RunsOnDbr=truetest actually uses ruff — only the local-onlycheck-formattingtest does. So the requirement is dead weight in DBR mode.What
Skip the ruff prerequisite when running in DBR mode (
WorkspaceTmpDir), mirroring the existing terraform-setup skip a few lines below. The local path is unchanged — ruff is still required there.