[PECO-AI] PECOBLR-1968: Add warnings in logs if someone uses a connection param that is not defined in python sql connector#743
Open
deeksha-db wants to merge 1 commit intomainfrom
Open
Conversation
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
| TRANSACTION_ISOLATION_LEVEL_REPEATABLE_READ = "REPEATABLE_READ" | ||
|
|
||
| # All supported **kwargs for Connection.__init__. Used to warn on unknown params. | ||
| KNOWN_KWARGS = frozenset( |
Contributor
There was a problem hiding this comment.
we should add a test test_known_kwargs_is_complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PECO Agent Workflow (Partner Ecosystem)
Jira Ticket: https://databricks.atlassian.net/browse/PECOBLR-1968
Changes
Added a
KNOWN_KWARGSfrozenset constant toclient.pylisting all supported**kwargsforConnection.__init__. In the constructor, right after the debug log, the code computesset(kwargs.keys()) - KNOWN_KWARGSand emits alogger.warningnaming any unrecognized parameter(s). This is a purely additive, backward-compatible change — unknown kwargs continue to be passed through; they just now generate a visible warning.Test Cases Written
test_unknown_connection_param_issues_warning— unknown kwarg triggerslogger.warningtest_unknown_connection_param_warning_names_the_param— warning message includes the param nameSummary: Added a
KNOWN_KWARGSfrozenset constant toclient.pylisting all supported**kwargsforConnection.__init__. In the constructor, right after the debug log, the code computesset(kwargs.keys()) - KNOWN_KWARGSand emits alogger.warningnaming any unrecognized parameter(s). This is a purely additive, backward-compatible change — unknown kwargs continue to be passed through; they just now generate a visible warning.