chore: upgrade Scala Native 0.5.11 -> 0.5.12#882
Open
He-Pin wants to merge 1 commit into
Open
Conversation
Motivation: Adopt the latest Scala Native 0.5.x patch release. The new artifacts are not yet mirrored to the Databricks JFrog repo, so fork-PR CI (which has no JFrog OIDC token, JFROG_ACCESS_TOKEN="dummy") cannot resolve them and fails with "unauthorized" on org.scala-native:tools_2.13:0.5.12 / test-runner. Modification: - Bump scalaNativeVersion from 0.5.11 to 0.5.12 (no source changes needed; native hash rendering keeps its existing bytesToHex helper). - fix-build-config.sh: when JFROG_ACCESS_TOKEN is "dummy" (fork PRs), resolve from public Maven Central instead of JFrog, so public dependency versions not yet mirrored to JFrog can still be validated. Also force mill --no-server, add curl retries, and pin MILL_VERSION for the fork path. Internal PRs keep using JFrog unchanged. Result: Native compile (-Werror, full LTO) and link succeed; native test suite 462/462 pass; CLI output byte-identical to 0.5.11 on the jrsonnet realworld configs (kube-prometheus, loki, mimir, tempo). Both fork (Maven Central) and internal (JFrog) CI repository paths verified locally in a sandbox.
bf8fe3a to
cfe0675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the native cross module from Scala Native 0.5.11 → 0.5.12 (release notes).
The version bump itself is source-free (native hash rendering keeps its hand-rolled
bytesToHexhelper;java.util.HexFormatis available in 0.5.12 but not needed). However, the 0.5.12 artifacts are not yet mirrored to the Databricks JFrog repo, so fork-PR CI — which has no JFrog OIDC token (JFROG_ACCESS_TOKEN="dummy", seeget-jfrog-token.sh) and whosehashFiles('build.mill')dep-cache key changes on this bump — fails to resolve them:So this PR also makes
fix-build-config.shfall back to public Maven Central on fork PRs:JFROG_ACCESS_TOKEN == "dummy"(fork PRs): resolve frommaven-central.storage.googleapis.com, forcemill --no-server, addcurlretries, and pinMILL_VERSION. This lets not-yet-mirrored public dependency versions be validated by fork CI.Verification
compile+nativeLinksucceed under-Werror+ full LTO.