Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit 4463ebe.
2 tasks
Author
|
🔁 |
Author
|
reopening to force tests to re-run 😈 |
…s/vt-migrate-squash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from GoGo to VT proto
Changes
This PR was primarily focused on optimizing the receive path. It is possible there are some regressions in other areas (e.g. Query) however, at this point we should just see if this is a viable way forward at all. If it isn't then we stop here. I can close this and follow up with some of the micro optimizations i've made (or planned to make) in a separate PR building on gogo. If this is a viable path forward then I/we can begin tracing down further regressions and making improvements such as enabling pooling in other places. and even re-thinking how the underlying TSDB works in prometheus to carry these changes all the way through -- which I believe could have a greater impact.
Verification