receive: Fix duplicate metric registration panic on hashring reload#313
Open
receive: Fix duplicate metric registration panic on hashring reload#313
Conversation
Hoist numShardsGauge creation out of NewMultiHashring into setupHashring so it is registered once and reused across config reloads, preventing a MustRegister panic when the same metric name is re-registered. Co-authored-by: Isaac
…nter Co-authored-by: Isaac
…ller Follow the same register/unregister pattern used by shuffleShardCacheMetrics: store the gauge on multiHashring, unregister it in Close(). This keeps the metric lifecycle internal to hashring.go and avoids changing the public NewMultiHashring signature. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist numShardsGauge creation out of NewMultiHashring into setupHashring so it is registered once and reused across config reloads, preventing a MustRegister panic when the same metric name is re-registered.
Changes
Verification