Implement metrics blocklisting in thanos with negation pattern support#314
Open
willh-db wants to merge 4 commits intodatabricks:db_mainfrom
Open
Implement metrics blocklisting in thanos with negation pattern support#314willh-db wants to merge 4 commits intodatabricks:db_mainfrom
willh-db wants to merge 4 commits intodatabricks:db_mainfrom
Conversation
yuchen-db
requested changes
Mar 21, 2026
Collaborator
yuchen-db
left a comment
There was a problem hiding this comment.
looks like some irrelevant commits are included. do you mind rebasing on latest db_main?
351c9fd to
d6a5398
Compare
yuchen-db
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--receive.blocklist-config-fileand applied before relabeling--receive.blocklist-config-reload-timerfor emergency blocking without restartsblocklist_dropped_series_total,blocklist_active_rules,blocklist_config_reload_total,blocklist_config_reload_err_totalVerification
handler_test.govalidating end-to-end blocklist behavior