[ENGMP-365] Add protection config loading, roundtrip wiring, and e2e tests#318
Open
yishi3-db wants to merge 6 commits intoyi-shi_data/yishi3-db/query-protection-middlewarefrom
Conversation
yishi3-db
changed the title
yishi3-db
force-pushed
the
yi-shi_data/yishi3-db/query-protection-middleware
branch
from
06c366f to
5dc9004
Compare
yishi3-db
force-pushed
the
yi-shi_data/yishi3-db/query-protection-roundtrip
branch
from
b82adf6 to
1f94550
Compare
yishi3-db
force-pushed
the
yi-shi_data/yishi3-db/query-protection-middleware
branch
2 times, most recently
from
1a833f5 to
2bce8ef
Compare
yishi3-db
force-pushed
the
yi-shi_data/yishi3-db/query-protection-roundtrip
branch
from
1f94550 to
91bb2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pkg/queryfrontend/protection_config.go: YAML config loading with SHA256-based file watchingpkg/queryfrontend/roundtrip.go: wireProtectionEngineinto the middleware chaincmd/thanos/query_frontend.go: add--protection-configflag, registerWatchConfigwithrun.Grouptest/e2e/query_frontend_test.go: e2e test verifying block returns 400 and log passes throughTest plan
loadRulesFromFileandWatchConfiginprotection_config_test.goTestQueryFrontendProtectione2e test