[ENGMP-365] Add protection triggered counter metric and log action logging#320
Open
yishi3-db wants to merge 4 commits intoyi-shi_data/yishi3-db/query-protection-roundtripfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you change, and why?
applyProtectionResult()to make it extensible for future actionslogaction: logs a message when a protection rule triggersthanos_query_frontend_protection_triggered_totalcounter metric with labelsaction(block/log) andrule(rule name)How do you know it works?
Verified in dev-aws-us-east-1-obs-integrationtest:
blockaction returns 403 and increments the counterlogaction logs the message and increments the counter