Automated Integration Test Goldens Update from CI#6035
Conversation
…cd9-8c99-dbd732b3396d)
Summary of ChangesHello @datacommons-robot-author, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves to synchronize the integration test golden files with the current system output. It ensures that the tests remain accurate and up-to-date by incorporating minor, expected numerical variations in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates golden test files with minor changes to floating-point scores. While this is an automated update, increasing the precision of these scores can make tests more brittle and sensitive to insignificant model variations. There is a repository guideline to round floating-point scores to a consistent, lower precision to improve test robustness. I've left specific comments suggesting rounding the updated values. It would be beneficial to update the automation script to handle this rounding automatically in the future.
| 0.38534, | ||
| 0.38184, | ||
| 0.3797 | ||
| 0.37971 |
There was a problem hiding this comment.
To improve test stability and reduce noise from minor model output variations, it's recommended to round floating-point scores to a consistent, lower precision. Rounding this value to 4 decimal places would align with the previous value and make the test less brittle.
| 0.37971 | |
| 0.3797 |
References
- Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.
| 0.63227, | ||
| 0.63222, | ||
| 0.6305, | ||
| 0.63049, |
There was a problem hiding this comment.
To improve test stability and reduce noise from minor model output variations, it's recommended to round floating-point scores to a consistent, lower precision. Rounding this value to 4 decimal places would align with the previous value and make the test less brittle.
| 0.63049, | |
| 0.6305, |
References
- Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.
This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log