Skip to content

Automated Integration Test Goldens Update from CI#6035

Merged
n-h-diaz merged 2 commits intomasterfrom
nl-golden-update-23fc5e86-af24-4cd9-8c99-dbd732b3396d
Feb 27, 2026
Merged

Automated Integration Test Goldens Update from CI#6035
n-h-diaz merged 2 commits intomasterfrom
nl-golden-update-23fc5e86-af24-4cd9-8c99-dbd732b3396d

Conversation

@datacommons-robot-author
Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @datacommons-robot-author, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves to synchronize the integration test golden files with the current system output. It ensures that the tests remain accurate and up-to-date by incorporating minor, expected numerical variations in the debug_info.json files, which are crucial for validating the detection API's behavior.

Highlights

  • Automated Golden File Update: This pull request automatically updates integration test golden files, specifically debug_info.json files, via a Cloud Build process. The changes reflect minor adjustments in expected output values.
  • Minor Numerical Adjustments: The updates involve very small, single-digit changes to floating-point numbers within the 'scores' arrays of the affected JSON files, indicating a slight shift in the calculated values.
Changelog
  • server/integration_tests/test_data/detection_api_bio/whattypesofgenesarefgfr1,apoe,andache/debug_info.json
    • Updated a floating-point value in the 'scores' array from 0.3797 to 0.37971.
  • server/integration_tests/test_data/detection_api_multivar/howarefactorslikeobesity,bloodpressureandasthmaimpactedbyclimatechange/debug_info.json
    • Updated a floating-point value in the 'scores' array from 0.6305 to 0.63049.
Activity
  • This pull request was automatically created by the datacommons-robot-author.
  • The changes were generated by a Cloud Build process, as indicated by the provided log link.
  • The primary activity is the automated update of golden files for integration tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates golden test files with minor changes to floating-point scores. While this is an automated update, increasing the precision of these scores can make tests more brittle and sensitive to insignificant model variations. There is a repository guideline to round floating-point scores to a consistent, lower precision to improve test robustness. I've left specific comments suggesting rounding the updated values. It would be beneficial to update the automation script to handle this rounding automatically in the future.

0.38534,
0.38184,
0.3797
0.37971
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve test stability and reduce noise from minor model output variations, it's recommended to round floating-point scores to a consistent, lower precision. Rounding this value to 4 decimal places would align with the previous value and make the test less brittle.

Suggested change
0.37971
0.3797
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

0.63227,
0.63222,
0.6305,
0.63049,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve test stability and reduce noise from minor model output variations, it's recommended to round floating-point scores to a consistent, lower precision. Rounding this value to 4 decimal places would align with the previous value and make the test less brittle.

Suggested change
0.63049,
0.6305,
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

@n-h-diaz n-h-diaz merged commit 7ab9141 into master Feb 27, 2026
11 checks passed
@n-h-diaz n-h-diaz deleted the nl-golden-update-23fc5e86-af24-4cd9-8c99-dbd732b3396d branch February 27, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants