Stabilize WeCom channel state and session isolation#184
Open
Atlas-SZ wants to merge 1 commit intodataelement:mainfrom
Open
Stabilize WeCom channel state and session isolation#184Atlas-SZ wants to merge 1 commit intodataelement:mainfrom
Atlas-SZ wants to merge 1 commit intodataelement:mainfrom
Conversation
Rebuild the WeCom runtime fix on top of the current mainline so the channel-state and session-isolation changes can merge independently. This keeps the scope to runtime connection status, disconnect handling, official SDK payload parsing, group-vs-p2p session keys, and the minimal UI feedback needed for save and disconnect actions. Constraint: WeCom AI Bot traffic uses official SDK fields like from_userid, chattype, and chatid Constraint: The fix must stand alone on upstream/main without pulling in org-sync or password-reset work Rejected: Reuse the old PR branch history directly | earlier iterations mixed in unrelated changes and made scope review harder Rejected: Add a proxy dependency for the websocket path | forcing proxy=None is sufficient for the local SDK path Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep channel runtime behavior and ChannelConfig feedback changes together; splitting them will reintroduce silent disconnect failures Tested: cd backend && .venv/bin/python -m pytest tests/test_wecom_stream.py tests/test_wecom_channel_api.py Tested: cd backend && .venv/bin/python -m ruff check app/api/wecom.py app/services/wecom_stream.py tests/test_wecom_channel_api.py tests/test_wecom_stream.py Tested: cd frontend && npm run build Not-tested: End-to-end live single-chat and group-chat exchanges against a running WeCom bot
Atlas-SZ
force-pushed
the
fix/wecom-channel-state-182
branch
from
7172f8e to
ef076f1
Compare
Contributor
Author
|
This PR has been rebuilt cleanly on top of It now contains only the WeCom runtime/session fix:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeCom channel configuration was executing correctly server-side, but the UI could misreport connection health and silently fail after disconnect because it tried to parse a 204 response as JSON. The stream path also treated official WeCom AI Bot payloads as if they used legacy field names, which let group messages fall into p2p sessions. This change makes runtime connection state authoritative, separates group and p2p session keys correctly, and adds explicit UI feedback for save and disconnect actions.
Constraint: WeCom AI Bot traffic arrives through the official SDK fields from_userid, chattype, and chatid
Constraint: Local macOS system proxy settings must not break the WeCom websocket client
Rejected: Adding python-socks as a local dependency | unnecessary once the SDK path is forced to proxy=None
Confidence: high
Scope-risk: moderate
Reversibility: clean
Directive: Do not treat websocket mode as connected in the UI without consulting the backend is_connected flag
Tested: backend/.venv/bin/python -m ruff check backend/app/api/wecom.py backend/app/services/wecom_stream.py backend/tests/test_wecom_channel_api.py backend/tests/test_wecom_stream.py
Tested: backend/.venv/bin/python -m pytest backend/tests/test_wecom_stream.py backend/tests/test_wecom_channel_api.py
Tested: cd frontend && npm run build
Tested: Real WeCom websocket connect and disconnect with local runtime config
Not-tested: End-to-end live single-chat and group-chat message exchange against the running bot
Related: #182
Summary
Checklist