Update dsfr#249
Conversation
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
Nice, I have only minor comments!
- don't forget the changelog
- some links are now underlined (license, orga on dataset card), has it been made on purpose?
| monospace; | ||
| } | ||
|
|
||
| :where(nav li):before { |
There was a problem hiding this comment.
Our Sanitize.css adds a • to the left of <li>. This rules was never triggered before but it adds really wide padding to our list of lang. There are PR in sanitize to fix this (csstools/sanitize.css#227, csstools/sanitize.css#234) but the project seems inactive.
There was a problem hiding this comment.
I don't remember what we've said before on
There was a problem hiding this comment.
This is only for <li> in <nav> and it didn't have this side effect on our header. But, we now have a list in the new translate component.
There was a problem hiding this comment.
Oh my, I see. But <li> are not showing correctly, example on https://www.data.gouv.fr/fr/datasets/table-de-passage-geographie-2022/, where Dans la cellule D2,, etc. is a <li> showing as a raw string.
There was a problem hiding this comment.
We must add number back to <ol>in markdown. We already did it for <ul>.
These wasn't possible before due to how DSFR displayed underlines. But they changed it so I added them. Orga links fail RGAA criterion 3.1 without the underline. For license, it's valid without underline but you can't know that it's a link without it. |
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
I think I'm good with this PR 👏
We can deal with <ol> support now or later :)
2 participants
Close datagouv/data.gouv.fr#865