Skip to content

updated readme, added colors to map, misc cleanup, new screenshot#1

Merged
derekeder merged 1 commit intomainfrom
dwe/readme-map-edits
Mar 12, 2026
Merged

updated readme, added colors to map, misc cleanup, new screenshot#1
derekeder merged 1 commit intomainfrom
dwe/readme-map-edits

Conversation

@derekeder
Copy link
Member

Overview

  • set some color styles for the map
  • removed footer, unused menu items, redundant title to make the map interface simpler
  • updated basemap to use CARTO positron
  • fix for postgres port number bug
  • removes .env requirement and example file
  • updates readme with new screenshot
  • updates readme ordering of steps

Demo

2026-datamade-code-challenge

Notes

Got this error in my stack trace when initially setting up the repo

Container map-postgres Healthy
map           | psql: error: could not translate host name "map-postgres" to address: Name or service not known
map           | Waiting 5 seconds for PostgreSQL to come up: postgres@map-postgres/map...
map           | psql: error: could not translate host name "map-postgres" to address: Name or service not known
map           | Waiting 5 seconds for PostgreSQL to come up: postgres@map-postgres/map...

I believe it was resolved after I changed the port mapping

}

export default function RestaurantPermitMap() {
const colors = ["#eff3ff", "#bdd7e7", "#6baed6", "#2171b5"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imported these from https://colorbrewer2.org/. may be worth keeping in

.then((data) => setCurrentYearData(data))
}, [currentUrl])

function getColor(pcntPermits) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a function we stub out but ask them to implement

fillOpacity: pcntPermits,
color: "#000000",
weight: 1,
fillOpacity: 0.7,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these default styles can be kept in

<TileLayer
attribution='&copy; <a href="https://www.openstreetmap.org/copyright">OpenStreetMap</a> contributors'
url="https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png"
url="https://{s}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}@2x.png"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

positron base map

- map-db-data:/var/lib/postgresql
ports:
- 32001:5432
- 5432:5432
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site would not successfully come up before changing this

@derekeder derekeder requested a review from antidipyramid March 12, 2026 16:42
Copy link
Collaborator

@antidipyramid antidipyramid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@derekeder derekeder merged commit 04f53f5 into main Mar 12, 2026
4 of 6 checks passed
@derekeder derekeder deleted the dwe/readme-map-edits branch March 12, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants