New-DbaFirewallRule - Fix binary path extraction and remove dead code#10294
Open
andreasjordan wants to merge 1 commit intodevelopmentfrom
Open
New-DbaFirewallRule - Fix binary path extraction and remove dead code#10294andreasjordan wants to merge 1 commit intodevelopmentfrom
andreasjordan wants to merge 1 commit intodevelopmentfrom
Conversation
- Replace unsafe -replace regex (returns original string on no match, so a non-matching BinaryPath would silently produce a wrong Program path) with -match + $Matches[1] for both sqlservr.exe and sqlbrowser.exe detection - Remove unused \$programNeeded variable (was set but never read) (do New-DbaFirewallRule) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in the executable-based firewall rule implementation added for issue #9229.
Changes
-replacefor binary path extraction: PowerShell's-replacereturns the original string unchanged when the pattern doesn't match. IfBinaryPathdidn't containsqlservr.exe/sqlbrowser.exe, the original path value would silently be used as the firewall rule'sProgrampath. Changed to-match+$Matches[1]` which only sets the path when the regex actually matched.$programNeededvariable: Was set in two places but never read — actual logic relied on checking$rule.Config.Programdirectly.Closes #9229
Generated with Claude Code