Skip to content

Comments

Let --checkup test for external executables#1585

Merged
rolandwalker merged 1 commit intomainfrom
RW/checkup-test-external-executables
Feb 19, 2026
Merged

Let --checkup test for external executables#1585
rolandwalker merged 1 commit intomainfrom
RW/checkup-test-external-executables

Conversation

@rolandwalker
Copy link
Contributor

Description

Let --checkup test for external executables:

  • less
  • fzf

and rework some formatting of the --checkup output.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Feb 19, 2026
@github-actions
Copy link

Findings

  1. Docs correctness: --checkup is misspelled as --cheeckup in the changelog entry. That’s user-facing and misleading.
    File: changelog.md:6

  2. Tests gap: New --checkup output (external executable checks and headings) isn’t covered by tests. If you have snapshot/CLI output tests elsewhere, add/update coverage to prevent regressions in the help/checkup output formatting.
    File: mycli/main.py:2354

If you want, I can draft a minimal test harness for --checkup output based on your existing CLI test patterns.

@rolandwalker rolandwalker force-pushed the RW/checkup-test-external-executables branch from 819292e to fd807e9 Compare February 19, 2026 11:47
 * less
 * fzf

and rework some formatting of the --checkup output.
@rolandwalker rolandwalker force-pushed the RW/checkup-test-external-executables branch from fd807e9 to d80af06 Compare February 19, 2026 11:48
Copy link
Contributor

@scottnemes scottnemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified checking for the executables works as expected

@rolandwalker rolandwalker merged commit e52c256 into main Feb 19, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/checkup-test-external-executables branch February 19, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants