You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Missing security-relevant escape-sequence coverage (low)
File: test/pytests/test_string_utils.py
Current tests only validate SGR-style ANSI (\x1b[31m...). Terminal-title sanitization should also be locked down for OSC/control-sequence forms (for example \x1b]0;...\x07), since those are common in title-setting/injection paths.
Action: add a test case for OSC-style sequences to ensure sanitize_terminal_title() strips them.
Missing carriage-return edge case (low)
File: test/pytests/test_string_utils.py \n and \r\n are tested, but bare \r is not. Current implementation removes \r (via control-char regex) rather than spacing it, which can collapse words unexpectedly.
Action: add a test for bare \r and assert intended behavior ("a b" vs "ab"), so this is explicit.
No correctness or regression bug found in the new test code itself.
Testing note
I could not execute the test locally because uv is not installed in this environment (uv: command not found).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test coverage for string_utils.py, and fix up the changelog.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).