Skip to content

Add more tests for parseutils.py #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandwalker merged 1 commit into from
Mar 31, 2026
+246 −67
Merged

Add more tests for parseutils.py #1758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions mycli/packages/parseutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,13 +379,18 @@ def query_is_single_table_update(query: str) -> bool:
if not parsed:
return False
statement = parsed[0]
return (
statement[0].value.lower() == 'update'
and statement[1].is_whitespace
and ',' not in statement[2].value # multiple tables
and statement[3].is_whitespace
and statement[4].value.lower() == 'set'
)
try:
retval = bool(
statement[0].value.lower() == 'update'
and statement[1].is_whitespace
and ',' not in statement[2].value # multiple tables
and statement[3].is_whitespace
and statement[4].value.lower() == 'set'
)
except IndexError:
retval = False

return retval


def is_destructive(keywords: list[str], queries: str) -> bool:
Expand Down Expand Up @@ -428,8 +433,3 @@ def normalize_db_name(db: str) -> str:
if database_token is not None and normalize_db_name(database_token.get_name()) == dbname:
result = keywords[0].normalized == "DROP"
return result


if __name__ == "__main__":
sql = "select * from (select t. from tabl t"
print(extract_tables(sql))
Loading
Loading