Skip to content

[fix] remove outputer from patch collector #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldmonster merged 3 commits into from
Feb 13, 2026
Merged

[fix] remove outputer from patch collector #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b897c6
[fix] return output collectors
ipaqsa Feb 13, 2026
d8b5caa
[fix] return output collectors
ipaqsa Feb 13, 2026
5a69623
[fix] return output collectors
ipaqsa Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkg/metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
package pkg

type OutputMetricsCollector interface {
MetricsCollector
Outputer
}

type MetricsCollector interface {
// Inc increments the specified Counter metric
Inc(name string, labels map[string]string, opts ...MetricCollectorOption)
Expand Down
2 changes: 0 additions & 2 deletions pkg/patch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import (
)

type PatchCollector interface {
Outputer

// object must be Unstructured, map[string]any or runtime.Object
Create(object any)
// object must be Unstructured, map[string]any or runtime.Object
Expand Down