Skip to content

Conversation

@nevermarine
Copy link
Collaborator

@nevermarine nevermarine commented Feb 6, 2026

Description

DVCR NodeGroupConfiguration now uses Containerdv1 config (conf.d) when CRI is Containerd and the registry module is disabled; otherwise it uses v2 (registry.d/certs.d).

Why do we need it, and what problem does it solve?

With the registry module enabled, containerd config must use the v2 layout to avoid conflicts. With it disabled, DVCR must use the v1 layout.

What is the expected result?

  • Registry module disabled and CRI is Containerd => script uses v1 path (conf.d).
  • Registry module enabled or CRI is Containerdv2 => script uses v2 paths (registry.d/certs.d).

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: ci
type: chore
summary: "Fix DVCR NodeGroupConfiguration to choose Containerd v1 vs v2 by CRI and registry module state at node render time."

@nevermarine nevermarine modified the milestones: v1.5.0, v1.6.0 Feb 6, 2026
@nevermarine nevermarine force-pushed the chore/ci/fix-ngc-for-dvcr branch from ed73ae9 to b07302b Compare February 6, 2026 16:02
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
@nevermarine nevermarine force-pushed the chore/ci/fix-ngc-for-dvcr branch from d6927b1 to b7be9c6 Compare February 10, 2026 14:29
@nevermarine nevermarine marked this pull request as ready for review February 10, 2026 15:49
@nevermarine nevermarine requested a review from diafour February 10, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants