chore(test): fix prechecks in e2e#2439
Draft
nevermarine wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
Signed-off-by: Maksim Fedotov <maksim.fedotov@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align the custom e2e precheck label filter parser with Ginkgo label filter syntax by treating
!as a negation prefix.Why do we need it, and what problem does it solve?
The e2e precheck loader parsed negated labels differently from Ginkgo. Ginkgo uses
!Slow, while the custom precheck filter expected~Slow. As a result, when running tests with--label-filter='!Slow', Ginkgo excluded slow specs correctly, but the precheck loader treated!Slowas a required label name, collected no matching specs, and skipped all non-common prechecks.This change removes that mismatch and makes precheck selection consistent with the actual Ginkgo run.
What is the expected result?
go tool ginkgo --label-filter='!Slow'.Checklist
Changelog entries