Skip to content

test: migrate VirtualMachineImageHotplug e2e test to new framework #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eofff wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test: migrate VirtualMachineImageHotplug e2e test to new framework #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dd1ae7
rewrite
Jun 4, 2026
2491c66
fix linter
Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/e2e/default_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ clusterTransport:
helperImages:
curlImage: "curlimages/curl"
testData:
imageHotplug: "/tmp/testdata/image-hotplug"
sizingPolicy: "/tmp/testdata/sizing-policy"
vmConfiguration: "/tmp/testdata/vm-configuration"
vmMigration: "/tmp/testdata/vm-migration"
Expand Down
7 changes: 3 additions & 4 deletions test/e2e/internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,9 @@ const (
)

type TestData struct {
ImageHotplug string `yaml:"imageHotplug"`
VMMigration string `yaml:"vmMigration"`
Sshkey string `yaml:"sshKey"`
SSHUser string `yaml:"sshUser"`
VMMigration string `yaml:"vmMigration"`
Sshkey string `yaml:"sshKey"`
SSHUser string `yaml:"sshUser"`
Comment on lines 113 to +116
Copy link
Copy Markdown
Contributor

@hardcoretime hardcoretime Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last legacy test case, and unused configurations and legacy test data should be removed as well.
Also, delete the .keep files in the test data directory.

}

type StorageClass struct {
Expand Down
Loading
Loading