chore(dvcr): remove unsupported s3 feature#2450
Open
universal-itengineer wants to merge 2 commits into
Open
Conversation
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
Add .github, api, hack, src, test, tools, tmp and CHANGELOG to .helmignore. These directories are not part of the deployed chart and may contain files larger than Helm's 5MB per-file limit (e.g. the cloned tools/kubeconform/kubeconform.git fixtures), which breaks `helm template`/`helm package` during local render validation. Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
yaroslavborbat
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the unsupported legacy S3 object storage configuration for DVCR.
The following options are dropped from the module config:
dvcr.storage.objectStorage.s3.accessKeydvcr.storage.objectStorage.s3.secretKeydvcr.storage.objectStorage.s3.regiondvcr.storage.objectStorage.s3.regionEndpointdvcr.storage.objectStorage.s3.bucketConcretely this PR:
ObjectStorage/s3branch fromopenapi/config-values.yamland its Russian localization inopenapi/doc-ru-config-values.yaml.dvcr.storage.typenow allows onlyPersistentVolumeClaim.REGISTRY_STORAGE_S3_*environment variables and the object-storage based HA branch fromtemplates/dvcr/_helpers.tpl, and removes the now-unused localdvcr.helm_lib_is_ha_to_valuehelper (DVCR PDB uses an explicitminAvailable: 0).dvcr-object-storage-credentialsSecret (s3AccessKey/s3SecretKey) fromtemplates/dvcr/secret.yaml.A second commit adds non-chart directories (
.github,api,hack,src,test,tools,tmp,CHANGELOG) to.helmignoreso thathelm template/helm packageno longer fails on files exceeding Helm's 5 MB per-file limit (e.g. the clonedtools/kubeconform/kubeconform.gitfixtures) during local render validation.Why do we need it, and what problem does it solve?
The S3 object storage path was unsupported legacy configuration that is no longer maintained. Keeping it in the public schema and Helm templates was misleading and added dead code paths. Removing it keeps DVCR storage configuration limited to the supported
PersistentVolumeClaimmode.What is the expected result?
dvcr.storage.type: PersistentVolumeClaim.Checklist
Changelog entries