Merged
Conversation
- Install powerpc-xenon-pe-* binutils from xbox360-binutils 2.45.1-1 in the backend Dockerfile, mirroring the gc-wii-binutils pattern - Configure XBOX360 platform with assemble/objdump/nm commands using the new powerpc-xenon-pe-* tools - Revert assemble_cmd/objdump_cmd/nm_cmd to non-nullable str (no longer needed now that xbox360 has proper binutils) - Remove has_assembler/has_objdump from platform JSON serialization
# Conflicts: # backend/Dockerfile # backend/compilers/compilers.linux.yaml # backend/coreapp/compilers.py # backend/coreapp/platforms.py # frontend/src/components/PlatformSelect/PlatformIcon.tsx
Includes TLS directory and GlobalMemoryStatus support which may fix the msvc_ppc_16.00.11886.00 segfault under wibo.
Collaborator
|
I think the icon might need some svg massaging 
and 
Also, might be nice to tweak the text justification to avoid this: but, other than that, amazing stuff! 
|
Collaborator
|
Raised a PR for the svg fixup.. if you change 64-bit to 64bit it fits.. which is kinda annoying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently blocked on decompme/compilers#47 and #1702.Without a workingasorobjdump, I was planning on updating the frontend to use the newhas_assemblerflag and disable target asm input. We could either display "Manual scratch creation unsupported" or show a file upload input to upload an obj instead.For diffing, I was planning on updating the main diff view to force-enable objdiff and use that as the default differ if!has_objdump.We now have https://github.com/encounter/xbox360-binutils, so we should be good to go.