Add way to link directly to a search

[hollow-owl]

Now search query appears in url so queries can be bookmarked.

https://decomp.me/?search=<search query>

[mkst]

What?

[hollow-owl]

Whatever you type in the search box will also show up in the url like https://decomp.me/?search=<search query> so that it the search can be linked to.

For example if I type in asdf then the url will become https://decomp.me/?search=mkst and if you go to that link it will have asdf in the search box.

[mkst]

Not sure what the point of it is though? What problem is being solved? Maybe if we had a dedicated search page it would make sense, but we don't - if you were interested in adding that, that could be cool.

[mkst]

Are you a user of the site?

[hollow-owl]

No, I just found out about https://decomp.dev/ and objdiff and https://decomp.me and all the other tools. I've been decompiling stuff locally and found out someone else had a scratch that was 100% of the functions I was doing but for another game.

So I wanted to have an easier way in objdiff to see if a function has already been decompiled for another game. I thought a good way to do this is to have objdiff have a direct link to search for that function. So this PR it to add a direct link since that isn't possible currently.

Currently in objdiff there is a way to create a new scratch on decomp.me but no easy way to see if there are existing scratchs for the function. A full search page would be cool.

[mkst]

A full search page would be cool.

Yeh we have an open issue for that.

I dont think this PR is particularly nice UX to open the search bar (especially on mobile):

For your use case maybe query the API e.g. https://decomp.me/api/search?name=foo ? .. but it's still not great (it's still just the results used for the search results) -- I still think this is best solved with a specific results page.

[ethteck]

I agree with @mkst here. I like the idea of this PR - linkable search results. But the current search dropdown isn't what should be linked to. We should first add the search page and then allow linking to that.

[mkst]

Sorry that this one didn't work out. In future you can discuss in our discord server (or on GitHub) any issue before you spend time working on something. If you are interested in adding a full search page that would be really useful for many users!