feat: DH-19246 Added rolling formula benchmarks #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanbrub
changed the title
lbooker42
reviewed
Jan 28, 2026
| } | ||
|
|
||
| @Test | ||
| void rollingFormulaTick0Group3Ops() { |
Collaborator
There was a problem hiding this comment.
These test the old (and slightly deprecated form of rolling formula) which allows a single formula to be executed on multple columns. The new formula call looks like this (where the input and output columns are specified in the formula field, and there is no param_token or cols field).
contains = rolling_formula_tick(formula="Contains=avg(num1)", rev_ticks=2000, fwd_ticks=3000)
""");
These tests are fine, but we should add some more tests that cover the new pathways as well.
lbooker42
reviewed
Jan 28, 2026
| } | ||
|
|
||
| @Test | ||
| void rollingFormulaTick3Groups3Ops() { |
Collaborator
There was a problem hiding this comment.
I don't think 3groups testing is needed for RollingFormula
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://deephaven.atlassian.net/browse/DH-19246