fix: log block eigenvalue summary events#8048
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf89862488
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Copyright (c) Microsoft Corporation. | ||
| # SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Add the required DeepSpeed Team header
In this new test file, the workspace AGENTS.md requires new files to include the license header # SPDX-License-Identifier: Apache-2.0 followed by # DeepSpeed Team; this header omits # DeepSpeed Team and adds a different first line, so it violates the repo's required new-file header.
Useful? React with 👍 / 👎.
Summary
self.block_eigenvalue.values()when building monitor summary eventsdict_valuesviewFixes #7983.
To verify
python -m py_compile deepspeed\runtime\engine.py tests\unit\runtime\test_engine.py(passed)git diff --check(passed)python -m pytest tests\unit\runtime\test_engine.py -qwas attempted on Windows, but collection failed before the test ran because this clone hascore.symlinks=falseanddeepspeed/acceleratorwas checked out as a plain text symlink file, sodeepspeed.acceleratorcannot be imported locally. The new test should run in the normal Linux checkout used by CI.