Avoid a crash when an external link in the manual has no handler#99
Open
jim-daf wants to merge 1 commit into
Open
Avoid a crash when an external link in the manual has no handler#99jim-daf wants to merge 1 commit into
jim-daf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps the external link launch in the manual screen so the app no longer goes down when there is no app available to open the link.
Right now any non file URL is passed to
startActivitydirectly. On a device with no browser or no handler for the intent that throwsActivityNotFoundExceptionand takes the screen with it. With this change the link still opens normally when a handler exists, and otherwise the exception is caught and a short message is shown.Closes #98.