feat(internal): improve format support in node and bun#6630
feat(internal): improve format support in node and bun#6630easrng wants to merge 3 commits intodenoland:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6630 +/- ##
==========================================
- Coverage 94.74% 94.73% -0.01%
==========================================
Files 583 583
Lines 46478 46488 +10
Branches 6523 6525 +2
==========================================
+ Hits 44036 44042 +6
- Misses 2399 2402 +3
- Partials 43 44 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2b5b348 to
59c70c3
Compare
kt3k
left a comment
There was a problem hiding this comment.
Thanks for the PR. This looks nice and aligned with our recent direction (towards more node compatibility).
Left some comments about test structure.
| assertEquals( | ||
| stripAnsiCode(format({ a: 1, b: 2 })), | ||
| `{ | ||
| if (typeof Deno.inspect === "function") { |
There was a problem hiding this comment.
Can you use ignore option of Deno.test instead of big if block to exclude some tests in some environment? ref https://docs.deno.com/api/deno/~/Deno.TestDefinition
| import "../../fs/unstable_chmod_test.ts"; | ||
| import "../../fs/unstable_umask_test.ts"; | ||
| import "../../fs/unstable_utime_test.ts"; | ||
| import "../../internal/format_test.ts"; |
|
Closing due to inactivity — this PR has been stale for almost 11 months. Review feedback from @kt3k (using If you'd like to revisit this, feel free to open a fresh PR with the requested changes. Thanks for the contribution! |
Adds support for formatting objects in recent node and bun versions using util.inspect without compromising the experience for users of other runtimes