Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the vendored MITM proxy dependency github.com/elazarl/goproxy to v1.7.2, aligning the repo with the latest known-good upstream release (avoiding the unreleased build break mentioned in #14) and refreshing vendor/ accordingly.
Changes:
- Bump
github.com/elazarl/goproxyfrom the previous pseudo-version tov1.7.2ingo.mod/go.sum. - Refresh vendored sources and
vendor/modules.txtto matchv1.7.2(including new internal packages likeinternal/http1parserandinternal/signer). - Upstream vendored changes include refactors in HTTP/HTTPS handling and WebSocket handling, plus various internal cleanups.
Reviewed changes
Copilot reviewed 1 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates the required goproxy module version to v1.7.2. |
| go.sum | Updates module checksums for the new goproxy version. |
| vendor/modules.txt | Updates vendored module metadata and adds new internal goproxy packages. |
| vendor/github.com/elazarl/goproxy/actions.go | Vendored upstream comment/style adjustments. |
| vendor/github.com/elazarl/goproxy/certs.go | Vendored upstream CA initialization changes (loads keypair in init). |
| vendor/github.com/elazarl/goproxy/chunked.go | Vendored upstream error-handling cleanup in chunk writer. |
| vendor/github.com/elazarl/goproxy/ctx.go | Vendored upstream context/logging tweaks and charset parsing refactor. |
| vendor/github.com/elazarl/goproxy/dispatcher.go | Vendored upstream request/response condition helper updates (host/path matching behavior changes). |
| vendor/github.com/elazarl/goproxy/doc.go | Vendored upstream documentation formatting updates. |
| vendor/github.com/elazarl/goproxy/h2.go | Vendored upstream HTTP/2 proxy robustness improvements (type-assert safety). |
| vendor/github.com/elazarl/goproxy/http.go | New vendored upstream HTTP request handling split out of proxy.go. |
| vendor/github.com/elazarl/goproxy/https.go | Vendored upstream HTTPS/MITM refactor, new parser/signer usage, and connection handling changes. |
| vendor/github.com/elazarl/goproxy/internal/http1parser/header.go | New vendored helper for extracting original header casing in HTTP/1. |
| vendor/github.com/elazarl/goproxy/internal/http1parser/request.go | New vendored HTTP/1 request reader supporting optional header canonicalization prevention. |
| vendor/github.com/elazarl/goproxy/internal/signer/counterecryptor.go | Vendored upstream move of signer RNG utilities into an internal package with ED25519 support. |
| vendor/github.com/elazarl/goproxy/internal/signer/signer.go | New vendored internal signer implementation used by TLS MITM. |
| vendor/github.com/elazarl/goproxy/logger.go | Vendored upstream signature change to use any. |
| vendor/github.com/elazarl/goproxy/proxy.go | Vendored upstream ServeHTTP refactor and header-copying behavior changes. |
| vendor/github.com/elazarl/goproxy/README.md | Vendored upstream README expansion/updates. |
| vendor/github.com/elazarl/goproxy/responses.go | Vendored upstream replacement of deprecated ioutil usage with io. |
| vendor/github.com/elazarl/goproxy/signer.go | Vendored upstream removal (signer moved under internal/signer). |
| vendor/github.com/elazarl/goproxy/websocket.go | Vendored upstream WebSocket handling refactor (connection hijacking + proxying changes). |
| vendor/github.com/elazarl/goproxy/.golangci.yml | Vendored upstream linter configuration file added. |
Bumps github.com/elazarl/goproxy to v1.7.2, the first proper tagged release. No breaking API changes, so no code modifications were needed. All tests pass with -race -count=2.
JamieMagee
force-pushed
the
jamiemagee/upgrade-goproxy-1.7.2
branch
from
f14c5a8 to
00954ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
github.com/elazarl/goproxyfromv0.0.0-20240726154733-8b0c20506380tov1.7.2.The Dependabot PR in #14 tries to go straight to v1.8.1, but that version has a build failure (see elazarl/goproxy#745). The fix landed upstream in elazarl/goproxy#749 but hasn't been released yet.
v1.7.2 is the latest version that works.