Draft
Conversation
Collaborator
|
Gwen I created it we had |
- Replace all uses of the local parseValue() wrapper with direct calls to postCssParseValue().
- Improve getValueOrUrl() to correctly filter protocol-relative URLs by normalizing them before validation.
- Filter out falsey URL values when collecting references from declarations.
- Update debug messages for clearer context ("url() in @value" -> "url() in declaration").
- Remove the now unused parseValue() helper.
XhmikosR
force-pushed
the
xmr/is-url-superb
branch
from
a21f262 to
6287000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joscha: not 100% sure this is the same, since is-url-superb seems to not work with
//(it's just using the Node.js URL constructor).But this is what postcss-values-parser is using: https://github.com/shellscape/postcss-values-parser/blob/d95ae33212a5b46e093db03cb4e841b830daceb7/lib/nodes/Word.js#L40
You probably have a better idea if this patch is OK or not. :)
PS. makes me wonder if postcss-values-parser can be used directly instead of using is-url-superb?