Link dashboard stat cards to filtered lists; getLength aborted consistency#506
Merged
Merged
Conversation
… aborted exclusion - getLength() now reuses pendingConditions() so it excludes terminally aborted jobs, matching getPendingCount()/getPendingStats(). This fixes the admin "Pending Jobs (new/current)" card header showing a count that the (aborted-aware) pending list below it did not contain. - Status search filter gains pending, running, failed and aborted values (alongside completed/in_progress/scheduled), each matching the corresponding dashboard stat-card count. - Dashboard Scheduled/Pending/Running/Failed stat cards now link to the job index filtered by the matching status, so they are clickable and land on exactly the jobs they count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getLength()now reusespendingConditions()so it excludes terminally aborted jobs, consistent withgetPendingCount()/getPendingStats()(from Exclude aborted jobs from pending count and stats #505). Fixes the admin "Pending Jobs (new/current)" card header counting jobs the aborted-aware pending list below it did not contain.statussearch filter gainspending,running,failed, andabortedvalues (alongsidecompleted/in_progress/scheduled), each matching the corresponding dashboard stat-card count exactly.stats_cardelement already accepted alink).Notes
pending= waiting (completed null, not fetched, no failure, due, not aborted) — mirrors$pendingJobs = totalPending - running - retriable-failed.