fix: coerce non-string suggestion values at the response boundary#871
Merged
Conversation
If a server or local lookup supplies a suggestion with a non-string `value` (e.g. numeric IDs), downstream string methods such as `toLowerCase`, `replace`, `substr`, and `indexOf` throw mid-render. `verifySuggestionsFormat` now coerces any non-string `value` to a string via `String(...)` (preserving the rest of the suggestion shape via shallow copy). The coercion is also applied to the function-lookup callback path and ahead of the ajax `onSearchComplete` fire so all callbacks see a normalized `Suggestion.value: string`, matching the declared TypeScript contract. Closes #844. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #844.
Summary
If a server or local lookup supplies a suggestion with a non-string
value(e.g. numeric IDs), downstream string methods such astoLowerCase,replace,substr, andindexOfthrow mid-render.verifySuggestionsFormatnow coerces any non-stringvalueto a string viaString(...), preserving the rest of the suggestion shape via shallow copy.onSearchCompletefire, so all callbacks see a normalizedSuggestion.value: string— matching the declared TypeScript contract.Test plan
Autocomplete non-string suggestion valueswith two specs (local lookup + function callback) — both fail onmasterwithTypeError: ... is not a function, both pass with the fix.npm test— 36 / 36).npm run lint && npm run format:check && npm run typecheck && npm run buildall green.🤖 Generated with Claude Code