Skip to content

Patch Oryx test to implement GetFileSize method and fix build failure #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
Closed

Patch Oryx test to implement GetFileSize method and fix build failure #1540

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5531ff
Initial plan
Copilot Jan 14, 2026
238f9b3
Pin Oryx repository to commit before GetFileSize breaking change
Copilot Jan 14, 2026
71bc4e8
Improve maintainability by moving Oryx commit hash to variable at top…
Copilot Jan 14, 2026
b25cf9f
Apply patch to implement GetFileSize instead of pinning to old commit
Copilot Jan 14, 2026
64d6e19
Add verification and skip logic for GetFileSize patch
Copilot Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/oryx/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,39 @@ mkdir -p ${ORYX}

git clone --depth=1 https://github.com/microsoft/Oryx $GIT_ORYX

# Patch MemorySourceRepo to implement ISourceRepo.GetFileSize method
# This fixes a breaking interface change introduced in upstream Oryx
# See: https://github.com/microsoft/Oryx/commit/21c559437d69cb43fd9b34f01f68c43ea4bce318
MEMORY_SOURCE_REPO_FILE="$GIT_ORYX/tests/Detector.Tests/MemorySourceRepo.cs"
if [ -f "$MEMORY_SOURCE_REPO_FILE" ]; then
# Check if GetFileSize is already implemented
if ! grep -q "GetFileSize" "$MEMORY_SOURCE_REPO_FILE"; then
Copy link

@sam-byng sam-byng Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Are we expecting the Oryx team to add GetFileSize implementation to their tests/Detector.Tests/MemorySourceRepo.cs ?

I think this null implementation sounds good as a temporary solution. But is the root solution not for Oryx to implement this on their side? Perhaps i'm missing something

Copy link

@sam-byng sam-byng Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like they've spotted the bug and fixed this now too, so perhaps we need to pull this microsoft/Oryx#2765

echo "Patching MemorySourceRepo to add GetFileSize implementation..."
# Add GetFileSize implementation before the GetGitCommitId method
sed -i '/public string GetGitCommitId()/i\
public long? GetFileSize(params string[] paths)\
{\
var path = Path.Combine(paths);\
if (!pathsToFiles.ContainsKey(path))\
{\
return null;\
}\
var content = pathsToFiles[path];\
return content?.Length;\
}\
' "$MEMORY_SOURCE_REPO_FILE"

# Verify the patch was applied
if grep -q "GetFileSize" "$MEMORY_SOURCE_REPO_FILE"; then
echo "Successfully patched MemorySourceRepo"
else
echo "Warning: Failed to patch MemorySourceRepo - build may fail"
fi
else
echo "MemorySourceRepo already has GetFileSize implementation, skipping patch"
fi
fi

if [[ "${PINNED_SDK_VERSION}" != "" ]]; then
cd $GIT_ORYX
dotnet new globaljson --sdk-version ${PINNED_SDK_VERSION}
Expand Down