dotnet: set up tab completions for SDK 10+#1596
Open
sliekens wants to merge 2 commits intodevcontainers:mainfrom
Open
dotnet: set up tab completions for SDK 10+#1596sliekens wants to merge 2 commits intodevcontainers:mainfrom
sliekens wants to merge 2 commits intodevcontainers:mainfrom
Conversation
sliekens
force-pushed
the
dotnet-completions
branch
2 times, most recently
from
a335f8f to
2930611
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds system-wide tab-completion script installation for .NET SDK 10+ by generating shell completion files via the new dotnet completions script command during feature installation.
Changes:
- Introduces an SDK-major-version gate helper (
is_at_least_sdk_version) to detect SDK 10+ (and skip runtime-only installs). - Adds
install_completionsto generate and install Bash/Zsh/Fish completion scripts into standard system directories. - Invokes
install_completionsfrom the main .NET feature install script after installing and linkingdotnet.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dotnet/scripts/dotnet-helpers.sh | Adds SDK version detection and completion-script generation/installation logic. |
| src/dotnet/install.sh | Calls completion installation after ensuring dotnet is available system-wide. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
sliekens
force-pushed
the
dotnet-completions
branch
from
2930611 to
b2cb1f4
Compare
Generate bash, zsh, and fish completion scripts using 'dotnet completions script' and place them in the standard system-wide completion directories: - /usr/share/bash-completion/completions/dotnet - /usr/share/zsh/site-functions/_dotnet - /usr/share/fish/vendor_completions.d/dotnet.fish Gated behind SDK 10+ via version check since the 'dotnet completions script' command is only available starting with .NET 10. Skipped for runtime-only installs. Reference: https://learn.microsoft.com/en-us/dotnet/core/tools/enable-tab-autocomplete
sliekens
force-pushed
the
dotnet-completions
branch
from
b2cb1f4 to
dc43177
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Kaniska244
requested changes
Mar 9, 2026
Kaniska244
previously approved these changes
Mar 9, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set up dotnet tab completions for .NET SDK 10+ installs using the new
dotnet completions scriptcommand.Changes
src/dotnet/scripts/dotnet-helpers.shis_at_least_sdk_versionhelper function that checks if the installed SDK meets a minimum major version threshold. Returns false for runtime-only installs (no SDK available).install_completionsfunction that generates completion scripts and drops them into standard system-wide directories:/usr/share/bash-completion/completions/dotnet/usr/share/zsh/site-functions/_dotnet/usr/share/fish/vendor_completions.d/dotnet.fishsrc/dotnet/install.shinstall_completionsafter SDK installation.Design decisions
dotnet completions scriptcommand is only available starting with .NET 10. Older versions use a different approach. The version check usesdotnet --versionto parse the major version.versionis set tonone, no SDK is installed, anddotnet --versionwill fail, causing the function to skip gracefully.Reference
https://learn.microsoft.com/en-us/dotnet/core/tools/enable-tab-autocomplete