fix: prevent JSON parsing when responseType is text#102
Open
AKN414-IND wants to merge 1 commit intodevelopit:masterfrom
Open
fix: prevent JSON parsing when responseType is text#102AKN414-IND wants to merge 1 commit intodevelopit:masterfrom
AKN414-IND wants to merge 1 commit intodevelopit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when i tried to get the data response as a text I found i was unable to get it so i went through the code and found that this the library calls JSON.parse() on the response data regardless of the responseType configuration. This causes issues when expecting plain text or when the response body is not valid JSON.
so the logic i add just check if responseType is json else just return the normal data