Config migration: typed config, VisualizationConfig, and bootstrap command#58
Config migration: typed config, VisualizationConfig, and bootstrap command#58
Conversation
gadomski
left a comment
There was a problem hiding this comment.
Is this idea here that forks will want to use the same contributor list, but change the repositories?
I don't get why we couldn't do that from the same config.toml?
|
Hm good point @gadomski The next feature is intended to make it so that a person can either bring a list of repositories as the starting point OR a list of contributors. So maybe I just made this change to make it make more sense to me, but I am not sure it's actually needed. If you think it's safer to keep as config.toml then I'm down to keep it. |
Yeah, let's keep it as a single config.toml. For the "i want to bring a list of contributors and build the respoitories" or vice-versa, let's add a |
…properties Keep repositories and contributors inline in config.toml. Add ContributorType enum, ContributorEntry model, VisualizationConfig, and core_contributors/community_contributors properties to Config. Update CLI to use core_contributors instead of devseed_contributors. Made-with: Cursor
Accepts a repos file (one owner/repo per line) or a contributors CSV and writes a config.toml. Auto-detects the input format. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
9280e3d to
0fab9fb
Compare
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Use a single organization value as the source of truth for chart naming. Bootstrap now accepts --organization/--org only, emits organization in config.toml, and Config derives page title from organization with backward compatibility for legacy organization_name. Made-with: Cursor
|
@gadomski okay good call. I think this is ready for review again. And it's a nice addition to this workflow for somebody to standup a new visual. |
gadomski
left a comment
There was a problem hiding this comment.
I tried "bootstrap" locally w/ a list of repos, and my subsequent discover command errored with:
$ contributor-network discover
Discovering repos for 0 core contributors...
Known repos: 4
============================================================
DISCOVERED REPOSITORIES (min 2 core contributors)
============================================================
No repos found with 2+ core contributors.
Try lowering --min-contributors or check GitHub token permissions.I think that's because the discover command won't work w/o contributors:
For the flow suggested by this PR to work, we'll need to refactor the discover command to work with an empty contributors list and a empty repo list.
Summary
Keeps all config in a single
config.toml(repositories + contributors inline) while adding typed data models.ContributorTypeenum,ContributorEntrymodel,VisualizationConfigfor typed config accesscore_contributors/community_contributorsproperties (first group = core, rest = community)contributor-network bootstrap <infile>command to generateconfig.tomlfrom a repos file or contributors CSVValue
Enables typed config access and the bootstrap workflow without breaking the existing single-file config format.