Draft
Conversation
|
🚀 Latest commit deployed to https://multistore-proxy-pr-12.development-seed.workers.dev
|
Delete ServerForwarder, AppState, request_handler, and axum_helpers. Rename run_s3s() to run(). Remove ProxyBackend impl from ServerBackend (only StoreFactory needed). Drop unused deps (axum, futures, http-body-util, oidc-provider, etc.). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace LambdaForwarder + ProxyGateway with s3s service. Add StoreFactory impl for LambdaBackend. Remove ProxyBackend impl, ReqwestHttpExchange, and OIDC/STS dependencies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace ProxyGateway + WorkerForwarder + JsBody with S3Service. Remove ProxyBackend impl, FetchHttpExchange, OIDC/STS route handlers. Rate limiting and bandwidth metering are temporarily disconnected pending s3s middleware adapters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the legacy ProxyGateway-based request pipeline now that all three runtimes (server, lambda, workers) use the s3s-based MultistoreService. Deleted core modules: - proxy.rs (1,144 lines) — the main ProxyGateway orchestrator - forwarder.rs — runtime-agnostic HTTP forwarding trait - middleware.rs — composable middleware chain (Middleware, Next, DispatchContext) - route_handler.rs — pre-dispatch request interception (RouteHandler, ProxyResult) - router.rs — path-based route matching via matchit - auth/sigv4.rs — SigV4 parsing/verification (now handled by s3s) - auth/identity.rs — identity resolution from SigV4 headers - auth/tests.rs — integration tests for the above auth modules - backend/request_signer.rs — outbound SigV4 request signing - backend/multipart.rs — multipart upload URL construction - api/request.rs — S3 request parsing into typed operations Deleted dependent code: - sts/route_handler.rs — STS route registration on legacy Router - oidc-provider/route_handler.rs — OIDC discovery route registration - cf-workers/rate_limit.rs — rate limiting via legacy Middleware Simplified: - backend/mod.rs — removed ProxyBackend trait and RawResponse - metering/lib.rs — removed MeteringMiddleware (kept UsageRecorder/QuotaChecker traits) - oidc-provider/backend_auth.rs — removed Middleware impl (kept resolve logic) - auth/mod.rs — kept only authorize and TemporaryCredentialResolver Removed unused deps from core: uuid, base64, hex, hmac, sha2, matchit Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update crate-layout.md and core README.md to reflect the removal of the legacy ProxyGateway pipeline and migration to s3s-based MultistoreService. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
s3s's default access check rejects all unsigned requests with "Signature is required" when auth is configured. Add MultistoreAccess implementing S3Access to allow anonymous requests through, since authorization (including anonymous access per bucket) is handled by BucketRegistry::get_bucket() inside each S3 operation handler. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alukach
force-pushed
the
main
branch
3 times, most recently
from
befe0ca to
0e8b416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm highly skeptical that this will work...