test (backupcronjob) : add unit tests for OpenShift related rbac functionality#1586
Merged
dkwon17 merged 1 commit intodevfile:mainfrom Feb 12, 2026
Merged
Conversation
rohanKanojia
requested review from
akurinnoy,
dkwon17 and
ibuziuk
as code owners
rohanKanojia
force-pushed
the
pr/test-backupcronjob-rbac
branch
from
7161ebb to
66b2ae9
Compare
Collaborator
|
LGTM |
dkwon17
approved these changes
Feb 12, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…tionality Add comprehensive unit tests for OpenShift RBAC-related functions in the backup cronjob controller, covering role and role binding generation for backup jobs. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/test-backupcronjob-rbac
branch
from
66b2ae9 to
0081165
Compare
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds comprehensive unit tests for OpenShift-specific RBAC functionality in the backupcronjob controller. These tests cover the creation and validation of Roles, RoleBindings, and ImageStreams required for workspace backups to the OpenShift internal registry.
The test suite includes three main test scenarios:
ensureJobRunnerRBACOpenShift functionality - Verifies that on OpenShift platforms, both RoleBinding and ImageStream resources are created with proper configurationensureImagePushRoleBinding- Tests RoleBinding creation with correct ClusterRole reference (system:image-builder), ServiceAccount subjects, and proper labelingensureImageStreamForBackup- Validates ImageStream resource creation with correct GVK, metadata, and spec configurationThese unit tests ensure that the backup cronjob controller correctly sets up the necessary RBAC permissions and resources to push backup images to the OpenShift internal registry.
What issues does this PR fix or reference?
Relates to #1572 - This PR adds test coverage that would have caught the authentication regression where the role name was accidentally changed from system:image-builder to system:image-puller, which prevented backup jobs from pushing images to the OpenShift internal registry.
Is it tested? How?
This PR only adds unit tests, it can be verified by running
make testPR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che