Fix cascade deletion order in bulk delete action#499
Draft
Copilot wants to merge 2 commits intofeature/AdminForth/1256/cascading-deletion-from
Draft
Fix cascade deletion order in bulk delete action#499Copilot wants to merge 2 commits intofeature/AdminForth/1256/cascading-deletion-from
Copilot wants to merge 2 commits intofeature/AdminForth/1256/cascading-deletion-from
Conversation
…tion Co-authored-by: SerVitasik <87546293+SerVitasik@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on cascading deletion order
Fix cascade deletion order in bulk delete action
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the bulk delete action (
configValidator.ts),connector.deleteRecordwas called beforecascadeChildrenDelete, meaning the parent record was deleted before child records were processed — the inverse of the correct order used inrestApi.ts.Changes
configValidator.ts: Swapped the call order socascadeChildrenDeleteruns beforeconnector.deleteRecord, matchingrestApi.tsWhy children-first: DB-level FK constraints prevent parent deletion while children still reference it. More importantly, if parent deletion fails after cascade completes, the parent record still exists — a consistent, recoverable state. The inverse (parent deleted, cascade fails) leaves orphaned child records referencing a non-existent parent.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.