Skip to content

fix: dispatch surface_published after npm publish for verify timing#5

Merged
caballeto merged 1 commit intomainfrom
fix/release-publish-verify-timing
Apr 11, 2026
Merged

fix: dispatch surface_published after npm publish for verify timing#5
caballeto merged 1 commit intomainfrom
fix/release-publish-verify-timing

Conversation

@caballeto
Copy link
Copy Markdown
Contributor

Summary

  • Adds a surface_published dispatch step in the publish job, immediately after npm publish succeeds
  • This triggers the monorepo's surface-publish-verify.yml at the right time (after the package is live on npm)
  • Previously, the verify workflow was triggered by surface_release which fires after build but before npm publish, causing ETARGET failures

Context

Companion PRs:

  • Monorepo: devhelmhq/mono — switches surface-publish-verify.yml from surface_releasesurface_published + adds multi-surface support
  • SDK-JS: devhelmhq/sdk-js — same dispatch step addition

Test plan

  • YAML syntax validated
  • Merge all 3 PRs, then trigger a CLI release to verify the full flow

Made with Cursor

The publish-verify workflow in the monorepo was triggered by
surface_release, which fires after build but before npm publish.
This caused ETARGET errors because the package wasn't on npm yet.

Add a surface_published dispatch step that fires immediately after
npm publish succeeds, so the monorepo can verify the live package.

Made-with: Cursor
@caballeto caballeto merged commit 09bdab0 into main Apr 11, 2026
3 checks passed
@caballeto caballeto deleted the fix/release-publish-verify-timing branch April 11, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant