This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Partial solution that, fixes #412#426
Open
jwgmeligmeyling wants to merge 1 commit intodevhub-tud:masterfrom
Open
Partial solution that, fixes #412#426jwgmeligmeyling wants to merge 1 commit intodevhub-tud:masterfrom
jwgmeligmeyling wants to merge 1 commit intodevhub-tud:masterfrom
Conversation
Partial fix for devhub-tud#412 by redirecting the user to the login page if the update request fails. However, due to adblock limitations, this approach is not guaranteed to work. A proper solution should exist of creating an login API endpoint and a JS login dialog.
jwgmeligmeyling
changed the title
jwgmeligmeyling
changed the title
Fastjur
reviewed
Jun 1, 2017
| $scope.assignment = res.data; | ||
| }, function() { | ||
| try { | ||
| location.reload(); |
Member
There was a problem hiding this comment.
This does not work in all browsers right? Or adblocked browsers
Fastjur
approved these changes
Jun 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #412 by redirecting the user to the login page if the update request fails.
However, due to adblock limitations, this approach is not guaranteed to work.
A proper solution should exist of creating an login API endpoint and a JS login dialog.