Skip to content

ci: fix redfish release workflow#824

Open
DevipriyaS17 wants to merge 2 commits intoredfishfrom
redfish_release
Open

ci: fix redfish release workflow#824
DevipriyaS17 wants to merge 2 commits intoredfishfrom
redfish_release

Conversation

@DevipriyaS17
Copy link
Contributor

Fixed redfish release workflow similar to console release

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (redfish@5ca1b5d). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             redfish     #824   +/-   ##
==========================================
  Coverage           ?   34.24%           
==========================================
  Files              ?      135           
  Lines              ?    14125           
  Branches           ?        0           
==========================================
  Hits               ?     4837           
  Misses             ?     8854           
  Partials           ?      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nmgaston
Copy link
Contributor

nmgaston commented Mar 6, 2026

I would assume it should have the headless assets created also for each OS. Maybe that is just because we haven't rebased in awhile and we don't have those changes in this branch yet.

REDFISH_TAG="${GITHUB_REF#refs/tags/}"
echo "Building release for tag: $REDFISH_TAG"

# Validate tag format - must be v*-redfish.preview.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing the tag validation ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the validation back, got removed by mistake

@DevipriyaS17 DevipriyaS17 marked this pull request as ready for review March 12, 2026 05:35
@DevipriyaS17
Copy link
Contributor Author

I would assume it should have the headless assets created also for each OS. Maybe that is just because we haven't rebased in awhile and we don't have those changes in this branch yet.

The reason i didn't include headless assets is per the ADR's explicit scoping decision (https://github.com/device-management-toolkit/console/wiki/ADR-Redfish-Integration) - headless variants are reserved for GA releases to keep preview releases focused on full UI-based evaluation.

@DevipriyaS17 DevipriyaS17 force-pushed the redfish_release branch 2 times, most recently from b086a61 to d0d98af Compare March 12, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants