Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## redfish #824 +/- ##
==========================================
Coverage ? 34.24%
==========================================
Files ? 135
Lines ? 14125
Branches ? 0
==========================================
Hits ? 4837
Misses ? 8854
Partials ? 434 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I would assume it should have the headless assets created also for each OS. Maybe that is just because we haven't rebased in awhile and we don't have those changes in this branch yet. |
61e6eb5 to
e742da3
Compare
| REDFISH_TAG="${GITHUB_REF#refs/tags/}" | ||
| echo "Building release for tag: $REDFISH_TAG" | ||
|
|
||
| # Validate tag format - must be v*-redfish.preview.* |
There was a problem hiding this comment.
Any reason for removing the tag validation ?
There was a problem hiding this comment.
Added the validation back, got removed by mistake
The reason i didn't include headless assets is per the ADR's explicit scoping decision (https://github.com/device-management-toolkit/console/wiki/ADR-Redfish-Integration) - headless variants are reserved for GA releases to keep preview releases focused on full UI-based evaluation. |
b086a61 to
d0d98af
Compare
Fixed redfish release workflow similar to console release