google: Document for service account-less access#74
Closed
whs wants to merge 2 commits intodexidp:mainfrom
Closed
Conversation
Contributor
|
Hi @whs, thanks for updating the docs! Please note, this repo requires commits to be DCO signed. |
Contributor
|
@whs I'm not able to do a technical review on this project, but I did a copy edit pass. |
Signed-off-by: Manatsawin Hanmongkolchai <git@whs.in.th>
Co-authored-by: Nate W. <4453979+nate-double-u@users.noreply.github.com> Signed-off-by: Manatsawin Hanmongkolchai <git@whs.in.th>
whs
force-pushed
the
whs/sa-less-group
branch
from
6dfecca to
8c0c550
Compare
Author
|
Thanks for the review, I applied the suggestion and added DCO. Now we wait for the code PR to merge. |
Contributor
|
Circling back (after a long time). I think I recommend that we close this PR (as well as dexidp/dex#1896). This PR is stale and now has merge conflicts, and the code PR hasn't been updated or interacted with in quite some time. I appreciate your effort here, @whs, feel free to reopen if you find some time to work on this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document for dexidp/dex#1896