chore: migrate rust/basic_ethereum to icp-cli#1395
Draft
marc0olo wants to merge 2 commits into
Draft
Conversation
Replaces dfx.json with icp.yaml using @dfinity/rust@v3.3.0 recipe. Moves Rust source from src/ into backend/, adds workspace Cargo.toml, Makefile with local-testable ethereum_address tests, updated README with icp-cli deploy instructions preserving Ethereum integration details, and CI workflow with icp-dev-env-rust:1.0.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
….0.1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
marc0olo
force-pushed
the
chore/migrate-rust-basic-ethereum-to-icp-cli
branch
from
2d51380 to
4a9e7a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0recipesrc/intobackend/subdirectory with workspaceCargo.tomlevm_rpccanister inicp.yamlfor local deployment (pre-built WASM from v2.2.0 release)Makefilewith 3 tests forethereum_address(locally testable via threshold ECDSA)icp-clideploy instructions, preserving all Ethereum integration details (Sepolia/Mainnet configs, send_eth steps, EIP-1559 notes, replicated HTTPS outcall caveats).github/workflows/basic_ethereum.ymlwithicp-dev-env-rust:1.0.0dfx.json,BUILD.md,basic_ethereum.did,.devcontainer/Notes
get_balance,transaction_count, andsend_ethrequire live HTTPS outcalls to Ethereum and cannot be tested in CI. Tests coverethereum_addresswhich uses threshold ECDSA (available locally). README documents mainnet-only functions clearly.Test plan
icp network start -d && icp deploysucceeds inrust/basic_ethereummake testpasses (3ethereum_addresstests using threshold ECDSA)rust/basic_ethereum/**🤖 Generated with Claude Code