chore: migrate rust/basic_bitcoin to icp-cli#1397
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
- Replace dfx.json with icp.yaml (Bitcoin integration via custom Docker image bundling bitcoind, matching motoko/basic_bitcoin pattern) - Move Rust source from src/ into backend/ subdirectory - Replace root Cargo.toml with workspace + backend/Cargo.toml (name=backend) - Copy Dockerfile and docker/start.sh from motoko/basic_bitcoin - Rewrite Makefile with icp-cli commands and 9 numbered tests - Update README with icp-cli instructions, preserve all domain content - Add rust-basic_bitcoin CI job to .github/workflows/basic_bitcoin.yml - Delete dfx.json, build.sh, basic_bitcoin.did, old src/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing the same Bitcoin Docker image pattern asmotoko/basic_bitcoin(custom image bundling bitcoind + IC network launcher)src/intobackend/subdirectory; replace flatCargo.tomlwith a workspace +backend/Cargo.toml(package namebackend)Dockerfileanddocker/start.shfrommotoko/basic_bitcoin(same bitcoind setup)Makefilewithicp canister call backend ...and 9 numbered tests covering address generation, balance, UTXOs, blockchain info, and block headersREADME.md: replace alldfxcommands withicp/icp-cli, preserve all domain-specific content (Bitcoin asset protocols, implementation notes, address type explanations)rust-basic_bitcoinjob to.github/workflows/basic_bitcoin.yml(runs on host, not container, so Docker bind-mounts work; includesdtolnay/rust-toolchainsetup step)dfx.json,build.sh,basic_bitcoin.did(backend-only, no frontend)Test plan
make build-imagebuilds the Docker image successfullyicp network start -d && icp deploy --cycles 30tdeploys the backend canistermake testruns all 9 tests (address generation, fee percentiles, mining 101 blocks, balance check, UTXOs, blockchain info, block headers)rust-basic_bitcoinin.github/workflows/basic_bitcoin.ymltriggers on changes torust/basic_bitcoin/**🤖 Generated with Claude Code