chore: migrate rust/composite_query to icp-cli#1398
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
- Replace dfx.json with icp.yaml using @dfinity/rust@v3.3.0 - Rename canisters: kv_frontend → caller, data_partition → callee - Move each canister into its own subdirectory (caller/, callee/) - Update workspace Cargo.toml to reference new members - Rewrite caller/lib.rs: replace ic_cdk::api::management_canister with ic-cdk-management-canister crate, replace ic_cdk::api::call::call with ic_cdk::call::Call::bounded_wait pattern - Add Makefile with 7 tests covering put, composite query get, get_update, null lookup, multi-partition routing, and lookup composite query - Add rust-toolchain.toml with wasm32-unknown-unknown target - Add rust-composite_query job to composite_query.yml workflow - Delete legacy rust-composite_query-example.yml workflow - Update README with icp-cli deploy instructions and architecture diagram Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0caller(waskv_frontend) andcallee(wasdata_partition), matching the Motoko counterpart namingcaller/,callee/) with a workspaceCargo.tomlcaller/lib.rsto useic-cdk-management-canister(replaces removedic_cdk::api::management_canister) andic_cdk::call::Call::bounded_waitfor cross-canister calls (replacesic_cdk::api::call::call)Makefilewith 7 tests coveringput, composite queryget,get_update, null lookup, multi-partition routing, andlookuprust-composite_queryjob to the existingcomposite_query.ymlworkflow and deletes the legacyrust-composite_query-example.ymlREADME.mdwith icp-cli deploy instructions and architecture diagramTest plan
icp network start -d && icp deploy --cycles 30tsucceeds inrust/composite_querymake testpasses all 7 testsrust-composite_queryjob passes in the workflow🤖 Generated with Claude Code