chore: migrate rust/canister_logs to icp-cli#1407
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
- Replace dfx.json with icp.yaml using @dfinity/rust@v3.3.0 - Move src/lib.rs → backend/lib.rs; add workspace Cargo.toml - Upgrade dependencies: ic-cdk 0.20, ic-cdk-timers 1.0, ic-cdk-management-canister 0.1.1 - Replace ic_cdk::api::management_canister with ic_cdk_management_canister::raw_rand - Add Makefile with 11 tests covering all public canister methods - Rewrite README with icp-cli deploy/test instructions - Add rust-canister_logs CI job (icp-dev-env-rust:1.0.0) to canister_logs.yml - Delete dfx.json, BUILD.md, poll_logs.sh, canister_logs.did, .devcontainer/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0(backend-only, nopackagefield needed)src/lib.rs→backend/lib.rs; rootCargo.tomlbecomes a workspace withmembers = ["backend"]ic-cdk 0.20,ic-cdk-timers 1.0,ic-cdk-management-canister 0.1.1ic_cdk::api::management_canisterwithic_cdk_management_canister::raw_randMakefilewith 11 numbered tests covering all public canister methods (print,print_query,trap,trap_query,panic,memory_oob,failed_unwrap,raw_rand, timer trap)rust-canister_logsCI job usingicp-dev-env-rust:1.0.0to the existingcanister_logs.ymlworkflowdfx.json,BUILD.md,poll_logs.sh,canister_logs.did,.devcontainer/devcontainer.json,package-lock.jsonTest plan
icp network start -d && icp deploysucceeds inrust/canister_logsmake testpasses all 11 tests locallyrust-canister_logsjob passesicp canister logs backendshows timer trap entries after 5 secondsicp canister logs --follow backendstreams logs in real time🤖 Generated with Claude Code