chore: migrate rust/candid_type_generation to icp-cli#1408
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
- Replace dfx.json with icp.yaml using @dfinity/rust@v3.3.0 recipe - Move src/ to backend/, add workspace Cargo.toml, rename package to backend - Update build.rs to resolve candid/ path relative to new backend/ location - Update scripts/fetch_candid.sh to use icp canister metadata instead of dfx - Add Makefile with test target for list_neurons_pretty - Add rust-toolchain.toml with wasm32-unknown-unknown target - Add CI workflow candid_type_generation.yml with icp-dev-env-rust:1.0.0 - Delete legacy rust-candid-type-generation-example.yml workflow - Regenerate Cargo.lock for new workspace structure Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing the@dfinity/rust@v3.3.0recipesrc/→backend/, adds workspaceCargo.toml, renames Cargo package tobackendbuild.rsto resolvecandid/nns_governance.didrelative to the newbackend/locationscripts/fetch_candid.shto useicp canister metadatainstead ofdfx canister --network ic metadataMakefilewith atesttarget that callslist_neurons_prettyrust-toolchain.tomlwithwasm32-unknown-unknowntargetcandid_type_generation.ymlusingghcr.io/dfinity/icp-dev-env-rust:1.0.0rust-candid-type-generation-example.ymlworkflow.gitignoreto un-ignorebackend/src/declarations/(committedic-cdk-bindgenoutput)Test plan
rust-candid_type_generationpasses on this PRicp network start -d && icp deploy && make testsucceeds locallymake testassertslist_neurons_prettyreturns a text response (success or expected error from local→mainnet inter-canister call)🤖 Generated with Claude Code