chore: migrate rust/threshold-schnorr to icp-cli#1409
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
- Replace dfx.json with icp.yaml using @dfinity/rust@v3.3.0 - Rename src/schnorr_example_rust/ to backend/ and update Cargo.toml package name to backend - Update ic-cdk from 0.16 to 0.20, replacing removed call_with_payment with ic_cdk::call::Call builder API - Rewrite Makefile with icp-canister-call-based test target covering all 5 tests including off-chain JS cryptographic verification via test.sh - Copy test.sh and package.json from motoko/threshold-schnorr for cross-language verification - Add rust-toolchain.toml with wasm32-unknown-unknown target - Add rust-threshold-schnorr job to threshold-schnorr.yml CI workflow using ghcr.io/dfinity/icp-dev-env-rust:1.0.0 - Delete dfx.json, BUILD.md, .devcontainer/, src/, and legacy rust-threshold-schnorr-example.yml workflow Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0src/schnorr_example_rust/tobackend/, renames package tobackendic-cdkfrom 0.16 to 0.20, replacing removedcall_with_paymentwith theic_cdk::call::Callbuilder APIMakefilewith 5-testtesttarget: public_key (×2), sign (×2), plus off-chain JS cryptographic verification viatest.shfor all three signature types (ed25519, bip340secp256k1, bip341)test.shandpackage.jsonfrommotoko/threshold-schnorr(identical canister interface)rust-toolchain.tomlwithwasm32-unknown-unknowntargetrust-threshold-schnorrjob to existingthreshold-schnorr.ymlCI workflow usingghcr.io/dfinity/icp-dev-env-rust:1.0.0dfx.json,BUILD.md,.devcontainer/,src/, oldrust-threshold-schnorr-example.ymlworkflowTest plan
icp network start -d && icp deploy && make testpasses inrust/threshold-schnorrrust-threshold-schnorrjob passes inthreshold-schnorr.ymlmotoko-threshold-schnorrjob is unaffected🤖 Generated with Claude Code