chore: migrate rust/threshold-ecdsa to icp-cli#1410
Draft
marc0olo wants to merge 1 commit into
Draft
Conversation
Replace dfx.json with icp.yaml (@dfinity/rust@v3.3.0), move src/ecdsa_example_rust/ to backend/, update Cargo.toml to workspace + backend package named "backend", migrate management canister ECDSA calls to ic-cdk-management-canister, update Makefile/test.sh/README for icp-cli, add rust-threshold-ecdsa CI job to threshold-ecdsa workflow, delete dfx.json, BUILD.md, .devcontainer/, and stale Cargo.lock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0src/ecdsa_example_rust/→backend/, renames package tobackendic_cdk::api::management_canister::ecdsatoic-cdk-management-canister = "0.1.1"Makefilewith numberedtesttarget callingicp canister call backendtest.shto useicp canister callinstead ofdfx canister callrust-threshold-ecdsaCI job to the existingthreshold-ecdsa.ymlworkflow (containerghcr.io/dfinity/icp-dev-env-rust:1.0.0)dfx.json,BUILD.md,.devcontainer/, staleCargo.lockTest plan
icp network start -d && icp deploysucceeds inrust/threshold-ecdsa/make testpasses: public key returned, signature returned, secp256k1 verification passesrust-threshold-ecdsapasses in the workflow🤖 Generated with Claude Code