chore: migrate rust/icp_transfer to icp-cli#1412
Draft
marc0olo wants to merge 2 commits into
Draft
Conversation
Replaces dfx.json with icp.yaml (@dfinity/rust@v3.3.0), moves the canister source from src/icp_transfer_backend/ to backend/, renames the Cargo package to `backend`, adds a Makefile that deploys the ICP ledger locally at ryjl3-tyaaa-aaaaa-aaaba-cai and runs end-to-end transfer tests, and adds a CI workflow using icp-dev-env-rust:1.0.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dfx.jsonwithicp.yamlusing@dfinity/rust@v3.3.0src/icp_transfer_backend/tobackend/, renames Cargo package tobackendMakefilewith 4 end-to-end tests: ledger balance check, fund backend canister,backend.transfercall, post-transfer balance checkmake testtarget deploys the ICP ledger locally atryjl3-tyaaa-aaaaa-aaaba-cai(same principal as mainnet) viaprovisional_create_canister_with_cycles, matching the hardcodedMAINNET_LEDGER_CANISTER_IDin the Rust code.github/workflows/icp_transfer.ymlusingghcr.io/dfinity/icp-dev-env-rust:1.0.0rust-icp-transfer-example.yml,dfx.json, anddemo.shTest plan
icp network start -d && icp deploy && make testpasses locallyrust-icp_transferjob passesOk)backend.transferof 0.5 ICP returnsOkwith a block index🤖 Generated with Claude Code